Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that msg.To() is not nil in GetVMEnv #51

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

gsalgado
Copy link
Contributor

Otherwise it will panic when msg is creating a contract.

Closes: #50

Otherwise it will panic when msg is creating a contract.

Closes: Consensys#50
@jpmsam
Copy link
Contributor

jpmsam commented Feb 10, 2017

Hi @gsalgado ,

Thank you for the pull request and for your contribution.

We have to send you a CLA to sign, can you please send the email address you'd like to receive it at to quorum_info@jpmorgan.com ?

Also, would you mind sharing the script and steps that you used to replicate issue #50 ?

Thanks,
Sam

@jpmsam jpmsam self-assigned this Feb 10, 2017
@gsalgado
Copy link
Contributor Author

Hi Sam,

Please send the CLA to guilherme.salgado@consensys.net.

Unfortunately I can't share the code (it's a Go unit test) that triggers #50 as it's a closed project, but basically what it does is use ethclient (via the contract bindings generated by abigen) to deploy a new contract.

Cheers,
Guilherme

@jpmsam jpmsam merged commit e6282c2 into Consensys:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants