Trigger primary BN readiness check when failover has issues

[StefanBratanov]

PR Description

Currently we wait onAttestationAggregationDue to trigger the readiness check for beacon nodes, which in turn trigger event streaming failing over/returning to primary. However, if there is a failover issue and there are no other failovers available, in some edge cases VC has to wait around a slot time before the onPrimaryNodeBackReady callback is called and the failover to primary can happen.

The edge case is onAttestationAggregationDue happens. Both primary and failover are in a bad state. We are still connected to a failover, so we try switching but nothing is available. In the meantime, primary has recovered. However, we still have to wait until the next onAttestationAggregationDue before reconnecting.

Fixed Issue(s)

related to #8180

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[mehdi-aouadi]

LGTM
I'd suggest adding a test for this edge case though.
Overall I'm thinking if we could de-correlate the readiness check from the onAttestationAggregationDue and make it run autonomously, async and time based or something like that...

[StefanBratanov]

LGTM I'd suggest adding a test for this edge case though. Overall I'm thinking if we could de-correlate the readiness check from the onAttestationAggregationDue and make it run autonomously, async and time based or something like that...

Good idea. Added a test.