Unhide IPv6/dual-stack options

[StefanBratanov]

PR Description

Unhide IPv6/dual-stack CLI options

Fixed Issue(s)

fixes #8069

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[rolfyone]

one note, this does kind of indicate there's no tests around any of these flags that were dev flags, as not one test broke... Maybe we should at least have a test that sets all the flags and checks values, and also maybe one that checks defaults?

oops is just draft.

[StefanBratanov]

one note, this does kind of indicate there's no tests around any of these flags that were dev flags, as not one test broke... Maybe we should at least have a test that sets all the flags and checks values, and also maybe one that checks defaults?

Good point. I will add couple of tests.

[StefanBratanov]

Dual-stack testing on Azure VMs

{
  "data": {
    "peer_id": "16Uiu2HAmS2wbEc4uWrG4wgt9Q9M6CqpbkrjjZVLQNqZ166dqG4Eq",
    "enr": "enr:-Ne4QF5D0VupPdhSKWZ3f2BlS6hiyu6Gcz1n588EcIFhXJbuPGJaj5KxsG7YNCElJWL8Y0Ir38-GKJnRt-c5jst79HISh2F0dG5ldHOIYAAAAAAAAACEZXRoMpBprg6ZBQFwAP__________gmlkgnY0gmlwhDSTE9aDaXA2kCYDEBAAAgACAAAAAAAAAMiJc2VjcDI1NmsxoQPGx5ZsyWMK75P7njAVf5DetfkkfyPA4USwmJI0nn18JoN0Y3CCIyiEdGNwNoIjgoN1ZHCCIyiEdWRwNoIjgg",
    "p2p_addresses": [
      "/ip4/52.147.19.214/tcp/9000/p2p/16Uiu2HAmS2wbEc4uWrG4wgt9Q9M6CqpbkrjjZVLQNqZ166dqG4Eq",
      "/ip6/2603:1010:2:2::c8/tcp/9090/p2p/16Uiu2HAmS2wbEc4uWrG4wgt9Q9M6CqpbkrjjZVLQNqZ166dqG4Eq"
    ],
    "discovery_addresses": [
      "/ip4/52.147.19.214/udp/9000/p2p/16Uiu2HAmS2wbEc4uWrG4wgt9Q9M6CqpbkrjjZVLQNqZ166dqG4Eq",
      "/ip6/2603:1010:2:2::c8/udp/9090/p2p/16Uiu2HAmS2wbEc4uWrG4wgt9Q9M6CqpbkrjjZVLQNqZ166dqG4Eq"
    ],
    "metadata": {
      "seq_number": "1",
      "attnets": "0x6000000000000000",
      "syncnets": "0x00"
    }
  }
}

Getting inbound/outbound connections

{
  "direction": "inbound",
  "count": 19
}
{
  "direction": "outbound",
  "count": 51
}

[StefanBratanov]

Tested locally with two nodes (IPv6 only)

[greptile-apps]

PR Summary

Unhid IPv6/dual-stack CLI options to enhance configurability for environments requiring both IPv4 and IPv6 support.

• Updated DiscoveryConfig.java to use --p2p-udp-port-ipv6 and --p2p-advertised-udp-port-ipv6 instead of hidden options.
• Modified NetworkConfig.java to remove the 'X' prefix from IPv6-related options, making them visible.
• Adjusted P2POptions.java to unhide IPv6 ports and advertised addresses, updating descriptions for clarity.
• Added tests in P2POptionsTest.java to verify default ports for IPv6 and dual-stack configurations.

_{4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[StefanBratanov]

Tested on Azure VMs:

First VM with second VM as a static peer (outbound):

Second VM has first VM as a peer (inbound)

[tbenr]

LGTM