Implement a DatabaseArchiveWriter and add to pruneOldestBlobSidecars #8640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Currently not configurable and only implements a NoopWriter.
5 tasks
|
welcome to |
tbenr
approved these changes
Sep 24, 2024
| @@ -81,6 +85,9 @@ public BlobSidecarPruner( | |||
| this.pruningActiveLabelledGauge = pruningActiveLabelledGauge; | |||
| this.storeNonCanonicalBlobSidecars = storeNonCanonicalBlobSidecars; | |||
|
|
|||
| // To be updated with other implementations. e.g. filesystem or s3 | |||
There was a problem hiding this comment.
I'd use // TODO: prefix so it will be captured nicely by intellij, or simply remove since we have a (set of) issues on the topic.
There was a problem hiding this comment.
I'll fix that up in the next PR. Thanks for feedback.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Initial change to add the concept of DatabaseArchiveWriter to pruneOldestBlobSidecars method. The initial implementation is a NoOp that returns true. See #8513 for additional tasks. With this change it sets up the structure. Future changes will implement a DatabaseArchive interface and required configuration options to configure where/how the archive is written.
Fixed Issue(s)
partially addresses #8513
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog