Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change keystores passwords to chararray #1046

Merged
merged 16 commits into from
Apr 29, 2020

Conversation

namtruong
Copy link
Collaborator

Update ssl keystore/truststore password fields also to use char[] instead of string.

An addition to previous PR #1041 and issue #792

@codecov-io
Copy link

codecov-io commented Apr 28, 2020

Codecov Report

Merging #1046 into master will increase coverage by 0.00%.
The diff coverage is 98.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1046   +/-   ##
=========================================
  Coverage     99.42%   99.43%           
- Complexity     2291     2296    +5     
=========================================
  Files           348      349    +1     
  Lines          6307     6327   +20     
  Branches        363      365    +2     
=========================================
+ Hits           6271     6291   +20     
  Misses            5        5           
  Partials         31       31           
Flag Coverage Δ Complexity Δ
#unittests 99.43% <98.48%> (+<0.01%) 2296.00 <36.00> (+5.00)
Impacted Files Coverage Δ Complexity Δ
...m/quorum/tessera/config/builder/ConfigBuilder.java 100.00% <ø> (ø) 39.00 <0.00> (ø)
...main/java/com/quorum/tessera/config/SslConfig.java 100.00% <ø> (ø) 48.00 <0.00> (ø)
...tessera/config/constraints/SslConfigValidator.java 97.80% <95.74%> (+0.21%) 58.00 <11.00> (ø)
...orum/tessera/config/adapters/CharArrayAdapter.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...quorum/tessera/config/util/ConfigSecretReader.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...m/tessera/config/util/EncryptedStringResolver.java 91.66% <100.00%> (ø) 4.00 <0.00> (ø)
...ssera/ssl/context/ClientSSLContextFactoryImpl.java 100.00% <100.00%> (ø) 8.00 <7.00> (ø)
.../quorum/tessera/ssl/context/SSLContextBuilder.java 100.00% <100.00%> (ø) 14.00 <4.00> (ø)
.../quorum/tessera/ssl/context/SSLKeyStoreLoader.java 100.00% <100.00%> (ø) 15.00 <1.00> (ø)
...ssera/ssl/context/ServerSSLContextFactoryImpl.java 100.00% <100.00%> (ø) 8.00 <7.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1afcdfe...e5fb674. Read the comment docs.

@Krish1979 Krish1979 merged commit 6346855 into master Apr 29, 2020
@namtruong namtruong deleted the change-keystores-passwords-to-chararray branch April 29, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants