-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change keystores passwords to chararray #1046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namtruong
requested review from
chris-j-h,
melowe,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
April 28, 2020 16:28
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
=========================================
Coverage 99.42% 99.43%
- Complexity 2291 2296 +5
=========================================
Files 348 349 +1
Lines 6307 6327 +20
Branches 363 365 +2
=========================================
+ Hits 6271 6291 +20
Misses 5 5
Partials 31 31
Continue to review full report at Codecov.
|
Krish1979
approved these changes
Apr 28, 2020
chris-j-h
approved these changes
Apr 29, 2020
nicolae-leonte-go
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ssl keystore/truststore password fields also to use char[] instead of string.
An addition to previous PR #1041 and issue #792