-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow no Q2T servers to be specified on a bootstrap node #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatpalSandhu61
requested review from
chris-j-h,
melowe,
namtruong,
nicolae-leonte-go and
prd-fox
as code owners
June 11, 2020 14:36
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
============================================
- Coverage 99.41% 99.39% -0.02%
- Complexity 2258 2261 +3
============================================
Files 349 349
Lines 6278 6289 +11
Branches 358 360 +2
============================================
+ Hits 6241 6251 +10
Misses 5 5
- Partials 32 33 +1
Continue to review full report at Codecov.
|
LFTM |
Krish1979
previously approved these changes
Jun 11, 2020
prd-fox
reviewed
Jun 12, 2020
config/src/main/java/com/quorum/tessera/config/constraints/ServerConfigsValidator.java
Outdated
Show resolved
Hide resolved
config/src/main/java/com/quorum/tessera/config/constraints/ServerConfigsValidator.java
Outdated
Show resolved
Hide resolved
config/src/main/java/com/quorum/tessera/config/constraints/ServerConfigsValidator.java
Outdated
Show resolved
Hide resolved
Clean up error messages. Minor change to clean up testing of ServerConfigs.
…ssue-790-bootstrap-node
prd-fox
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #790
Add new config item "bootstrapNode" which facilitates setup of a bootstrap node with no Q2T serverConfig entries.