Using object for RecipientBox rather than bytearray #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/jpmorganchase/tessera into strong-typed-object � Conflicts: � tessera-core/src/test/java/com/quorum/tessera/transaction/TransactionManagerTest.java � tessera-partyinfo/src/main/java/com/quorum/tessera/partyinfo/ResendManagerImpl.java
namtruong
requested review from
chris-j-h,
melowe,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
melowe
approved these changes
Jul 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
============================================
- Coverage 99.37% 99.34% -0.03%
- Complexity 2297 2309 +12
============================================
Files 354 355 +1
Lines 6400 6440 +40
Branches 363 372 +9
============================================
+ Hits 6360 6398 +38
Misses 5 5
- Partials 35 37 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
melowe
added a commit
that referenced
this pull request
Jul 21, 2020
* Reduce dependnecy on spring and make modules for creating their object factories. Provide more fine gran control of db transactions. * Reremove travis changes that weren't merged to QE repo and PSV branch * provide TransactionManagerFactory . Make PartyInfoServiceFactory work the same way. * test create part info service function * Add EntityManagerTemplate to control database transactions. Improve unit tests Upgrade version of eclipselink * Use HikariCP for connection pooling datasource * Update spring xml file. TransactionManager to use save with publish callback * add test coverage for transactionmanager * catch exceptions and fix some tests * fix eclipselink version in gradle * Propagate version headers (#1098) Bare minimum population of version info in http headers. Integraton test to insure these are propagated also over unix socket file. Initial default behaviour reads manifest file for version.Use ApiVersion definition from service loader as a means for defining the supported versions. * Using object for RecipientBox rather than bytearray (#1100) * Using object for RecipientBox rather than byte[] * update transactionmanager unit tests * update encodedpayloadbuilder unit tests * merge master to encapsulation improvements branch. a few renamed files didn't seem to get merged. * only add additional classpath elements arg if there are any elements Co-authored-by: namtruong <nam.p.truong@outlook.com> Co-authored-by: Krish1979 <39480483+Krish1979@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create specific immutable type for RecipientBox rather than byte[].
Make list unmodifiable