Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy group manager and publishers #1225

Merged
merged 19 commits into from
Feb 1, 2021
Merged

Conversation

namtruong
Copy link
Collaborator

A part of #1216.

This PR is specific to

  • PrivacyGroup related domain objects
  • Utility to encode and decode privacy group data, calculate privacy group ids from members
  • PrivacyGroupManager that handles logic for privacy groups including create, find, retrieve, store, delete
  • Publisher to publish privacy group encoded data to its members
  • Api version 3.0 to indicate a node's support for privacy group

@codecov-io
Copy link

codecov-io commented Jan 29, 2021

Codecov Report

Merging #1225 (ddbe49a) into master (4124af8) will increase coverage by 0.00%.
The diff coverage is 99.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #1225    +/-   ##
==========================================
  Coverage     99.52%   99.53%            
- Complexity     3115     3176    +61     
==========================================
  Files           472      488    +16     
  Lines          9134     9442   +308     
  Branches        474      483     +9     
==========================================
+ Hits           9091     9398   +307     
  Misses            5        5            
- Partials         38       39     +1     
Flag Coverage Δ Complexity Δ
unittests 99.53% <99.67%> (+<0.01%) 0.00 <61.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../java/com/quorum/tessera/enclave/PrivacyGroup.java 98.36% <98.36%> (ø) 0.00 <0.00> (?)
...a/com/quorum/tessera/enclave/PrivacyGroupUtil.java 100.00% <100.00%> (ø) 10.00 <10.00> (?)
...om/quorum/tessera/version/PrivacyGroupVersion.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...orum/tessera/privacygroup/PrivacyGroupManager.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
.../tessera/privacygroup/PrivacyGroupManagerImpl.java 100.00% <100.00%> (ø) 21.00 <21.00> (?)
...group/exception/PrivacyGroupNotFoundException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...p/exception/PrivacyGroupNotSupportedException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...ygroup/exception/PrivacyGroupPublishException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...oup/publish/BatchPrivacyGroupPublisherFactory.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...acygroup/publish/PrivacyGroupPublisherFactory.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4124af8...02da3b1. Read the comment docs.

@Krish1979 Krish1979 merged commit 443706f into master Feb 1, 2021
@namtruong namtruong deleted the privacy-group-manager branch February 2, 2021 19:47
@Krish1979 Krish1979 added 21.1.1 Tessera Q1 2021 release Besu Compatibility labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21.1.1 Tessera Q1 2021 release Besu Compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants