Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config-option as an alias for config file #1346

Merged
merged 8 commits into from
Nov 18, 2021

Conversation

namtruong
Copy link
Collaborator

@namtruong namtruong commented Nov 18, 2021

Replacement for #1344 raised by @frankisawesome

Replacement for #1345 raised by @macfarla

Fixes #1343

frankisawesome and others added 7 commits November 16, 2021 15:53
Signed-off-by: Frank Li <b439988l@gmail.com>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Frank Li <b439988l@gmail.com>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Copy link
Collaborator

@Krish1979 Krish1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krish1979 Krish1979 merged commit e0201c4 into master Nov 18, 2021
@frankisawesome
Copy link
Contributor

Thank you @namtruong

@namtruong namtruong deleted the feature/config-option-alias branch December 8, 2021 23:48
@Krish1979 Krish1979 added 22.1.0 2022 First Tessera release feature User features labels Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22.1.0 2022 First Tessera release feature User features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add --config-file as an alternative name for --configfile
4 participants