-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple payload encoder and add CBOR as an encoding mechanism #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on remoteNodeInfo
namtruong
requested review from
chris-j-h,
Krish1979 and
nicolae-leonte-go
as code owners
November 24, 2021 19:32
prd-fox
reviewed
Nov 30, 2021
enclave/enclave-api/src/main/java/com/quorum/tessera/enclave/EncodedPayloadCodec.java
Show resolved
Hide resolved
tessera-recover/src/main/java/com/quorum/tessera/recovery/internal/RecoveryImpl.java
Show resolved
Hide resolved
LGTM |
Krish1979
approved these changes
Dec 8, 2021
prd-fox
approved these changes
Dec 8, 2021
chris-j-h
approved these changes
Dec 8, 2021
Krish1979
added
22.1.0
2022 First Tessera release
enhancement
Non-user code enhancements
labels
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another type of payload encoding (CBOR) as the preferred codec with the view of replacing the legacy binary encoding mechanism. This is to make the
EncodedPayload
more extensible and also an enabler to accommodate any interoperability requirements in the future. Changes includeEncodedPayloadCodec
and store in an extra database column. Purpose of this is to maintain backward compatibility.EntityListeners
that handle data encoding/decoding from/to databaseFor now the scope of the change is for pushing payload between Tessera peer-to-peer
Part of the change was initially done in PR #1335 by @melowe