Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bind address separate to advertised address #448

Merged
merged 22 commits into from
Sep 10, 2018
Merged

Add bind address separate to advertised address #448

merged 22 commits into from
Sep 10, 2018

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Sep 7, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 7, 2018

Codecov Report

Merging #448 into master will decrease coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #448      +/-   ##
===========================================
- Coverage     99.76%   99.7%   -0.06%     
  Complexity     1033    1033              
===========================================
  Files           163     163              
  Lines          3439    3440       +1     
  Branches        189     189              
===========================================
- Hits           3431    3430       -1     
- Partials          8      10       +2
Impacted Files Coverage Δ Complexity Δ
...n/java/com/quorum/tessera/config/ServerConfig.java 100% <100%> (ø) 12 <4> (+2) ⬆️
...m/quorum/tessera/config/builder/ConfigBuilder.java 100% <100%> (ø) 38 <0> (ø) ⬇️
...m/quorum/tessera/api/filter/IPWhitelistFilter.java 96.29% <100%> (-3.71%) 8 <0> (-1)
...va/com/quorum/tessera/socket/HttpProxyFactory.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...om/quorum/tessera/api/filter/PrivateApiFilter.java 92.85% <66.66%> (-7.15%) 7 <1> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05eef62...878b190. Read the comment docs.

@Krish1979 Krish1979 merged commit 318ee6b into Consensys:master Sep 10, 2018
@Krish1979 Krish1979 deleted the add-bind-address branch September 10, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7 enhancement Non-user code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants