-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/grpc #451
Merged
Merged
Feature/grpc #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n acceptance tests
that mediates between enclave and base64 codecs.Rename grpc port to follow java conventions. Add convertor that copies properties to and from grpc objects and the existing rest model objects. Added initial acceptance test for Grpc send.
Port logic from grpc and rest resources into delegate object
when do config migration default this to be using REST
Fix unused imports in app module. Only run rest tests from failsafe for now.
by communication type.
into specialised java object rather than doing this in groovy.
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
===========================================
- Coverage 99.7% 99.7% -0.01%
- Complexity 1033 1106 +73
===========================================
Files 163 176 +13
Lines 3440 3669 +229
Branches 189 189
===========================================
+ Hits 3430 3658 +228
- Partials 10 11 +1
Continue to review full report at Codecov.
|
fix acceptance test suites
Feature/grpc
Test for validations.
Check strings are not empty
melowe
approved these changes
Sep 13, 2018
melowe
approved these changes
Sep 13, 2018
prd-fox
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gRPC capability for tessera. The communication protocol can be switchable using an additional config flag communicationType (possible values REST, GRPC). Default is REST