Allow private key password change #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create parsers for each type of CLI option. Each parser is responsible for it's own options and actions. This way, not everything is put into one super CLI class. Add ability to change, add or remove a password on a private key. This option is only for file based private keys, and will stop other CLI parsing from taking place, including but not limited to: - new key generation - configuration file loading and validating - application startup The rules and CLI options can be found in the attached issue.
…o feature/allow-privatekey-password-change
prd-fox
requested review from
chris-j-h,
namtruong and
SatpalSandhu61
as code owners
Revert change
namtruong
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#447
Create parsers for each type of CLI option. Each parser is responsible
for it's own options and actions. This way, not everything is put into
one super CLI class.
Add ability to change, add or remove a password on a private key. This
option is only for file based private keys, and will stop other CLI
parsing from taking place, including but not limited to:
The rules and CLI options can be found in the attached issue.