Decouple Azure key vault module #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pre-emptive change to prevent a cyclical dependency when trying to use the key-vault-api module in the keypairconverter as part of the upcoming refactor
# Conflicts: # config-cli/src/test/java/com/quorum/tessera/config/cli/OverrideUtilTest.java # config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java # config/src/main/java/com/quorum/tessera/config/KeyVaultConfig.java
Change to AzureKeyVaultConfig and remove type property
chris-j-h
requested review from
melowe,
namtruong,
SatpalSandhu61,
prd-fox and
nicolae-leonte-go
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
- Coverage 99.41% 99% -0.41%
- Complexity 1462 1476 +14
==========================================
Files 233 241 +8
Lines 4459 4533 +74
Branches 224 226 +2
==========================================
+ Hits 4433 4488 +55
- Misses 5 23 +18
- Partials 21 22 +1
Continue to review full report at Codecov.
|
melowe
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the coupling of the Azure key vault module to the core application code and make it easier to add new key vault implementations. The following changes have been made:
KeyVaultServiceFactoryto centralise creation of vault objects and use Java ServiceLoader to load implementationsKeyVaultConfiginterface-keygenvaulttypeCLI option if storing in a vault