Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Hashicorp acceptance tests #605

Merged
merged 18 commits into from Jan 21, 2019
Merged

Expand Hashicorp acceptance tests #605

merged 18 commits into from Jan 21, 2019

Conversation

chris-j-h
Copy link
Collaborator

  • Add tests for Hashicorp TLS and authentication methods
  • Sample certificates and keystores have been added for use in acceptance tests
  • Re-enable JDK 11 Travis build

@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #605 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #605      +/-   ##
============================================
+ Coverage     99.46%   99.46%   +<.01%     
  Complexity     1709     1709              
============================================
  Files           264      264              
  Lines          5216     5218       +2     
  Branches        252      252              
============================================
+ Hits           5188     5190       +2     
  Misses            5        5              
  Partials         23       23
Impacted Files Coverage Δ Complexity Δ
.../key/vault/hashicorp/HashicorpKeyVaultService.java 100% <100%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c7906...4984c11. Read the comment docs.

@Krish1979 Krish1979 merged commit ce45b7a into Consensys:master Jan 21, 2019
@Krish1979 Krish1979 deleted the improvement/hashicorp-tls-tests branch January 21, 2019 11:05
@prd-fox prd-fox added this to the 0.9 milestone Feb 21, 2019
@Krish1979 Krish1979 added the 0.9 label Apr 9, 2019
@Krish1979 Krish1979 added the enhancement Non-user code enhancements label Apr 9, 2019
@Krish1979 Krish1979 removed this from the 0.9 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9 enhancement Non-user code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants