-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Hashicorp acceptance tests #605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chris-j-h
commented
Jan 21, 2019
- Add tests for Hashicorp TLS and authentication methods
- Sample certificates and keystores have been added for use in acceptance tests
- Re-enable JDK 11 Travis build
…o improvement/hashicorp-tls-tests
…o improvement/hashicorp-tls-tests
chris-j-h
requested review from
melowe,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
January 21, 2019 10:35
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
============================================
+ Coverage 99.46% 99.46% +<.01%
Complexity 1709 1709
============================================
Files 264 264
Lines 5216 5218 +2
Branches 252 252
============================================
+ Hits 5188 5190 +2
Misses 5 5
Partials 23 23
Continue to review full report at Codecov.
|
prd-fox
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.