-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve node key pair information using admin API #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-j-h
requested review from
melowe,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
February 20, 2019 15:45
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
============================================
+ Coverage 99.42% 99.43% +<.01%
- Complexity 1863 1869 +6
============================================
Files 289 290 +1
Lines 5782 5801 +19
Branches 273 274 +1
============================================
+ Hits 5749 5768 +19
Misses 5 5
Partials 28 28
Continue to review full report at Codecov.
|
prd-fox
suggested changes
Feb 20, 2019
jaxrs-service/src/main/java/com/quorum/tessera/admin/ConfigResource.java
Outdated
Show resolved
Hide resolved
jaxrs-service/src/main/java/com/quorum/tessera/admin/ConfigResource.java
Outdated
Show resolved
Hide resolved
prd-fox
suggested changes
Feb 20, 2019
jaxrs-service/src/main/java/com/quorum/tessera/admin/ConfigResource.java
Outdated
Show resolved
Hide resolved
New DTO improves formatting of response data
prd-fox
reviewed
Feb 20, 2019
jaxrs-service/src/main/java/com/quorum/tessera/admin/PublicKeyResponse.java
Show resolved
Hide resolved
Remove setter and replace with constructor, make default constructor private so it cannot be used but is present for marshalling
prd-fox
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adminhost:port/config/keypairs
endpoint to retrieve all key pairs for a particular node. Example response is:adminhost:port/config/keypairs/{publickey}
endpoint to check if node is registered with a particular key pair. Example response is:if the node is registered with the key pair, and:
if node is not registered with the key pair