Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Transaction Manager Launcher #660

Merged
merged 1 commit into from Mar 21, 2019
Merged

Cleanup Transaction Manager Launcher #660

merged 1 commit into from Mar 21, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Mar 19, 2019

Background server threads mean the process will not terminate until required, and even then it will not exit with a code of 0. Therefore, there is no need to have the CountdownLatch waiting for termination of the main thread.


if (!cliResult.getConfig().isPresent() && cliResult.isSuppressStartup()) {
    System.exit(cliResult.getStatus());
}

was impossible to get into, due to a prior check for cliResult.isSuppressStartup() causing a System.exit if true. It also doesn't make sense as if this check could be entered, the only valid exit code is 0, so this has been removed entirely. All operations that don't create a config object should set the suppressed startup flag.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #660 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #660   +/-   ##
========================================
  Coverage      99.5%   99.5%           
  Complexity     1836    1836           
========================================
  Files           281     281           
  Lines          5487    5487           
  Branches        268     268           
========================================
  Hits           5460    5460           
  Misses            5       5           
  Partials         22      22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c0f76...61e6f19. Read the comment docs.

@melowe melowe merged commit 20dd6e5 into Consensys:master Mar 21, 2019
@melowe melowe deleted the cleanup-launcher branch March 21, 2019 11:49
@prd-fox prd-fox added this to the QE - March Deliverable milestone Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants