Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close streams after they are used #721

Merged
merged 4 commits into from
Apr 29, 2019
Merged

Close streams after they are used #721

merged 4 commits into from
Apr 29, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Apr 29, 2019

Follow-up of #719
Part of #705

Close input streams after they are used so we don't hit descriptor limits.
This only matters when using the directory store mode for loading data. We close each stream after it is used so that we don't have a bunch of dangling file descriptors and hit the limit.

melowe
melowe previously approved these changes Apr 29, 2019
@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9ada92c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #721   +/-   ##
=========================================
  Coverage          ?   99.44%           
  Complexity        ?     1890           
=========================================
  Files             ?      285           
  Lines             ?     5621           
  Branches          ?      284           
=========================================
  Hits              ?     5590           
  Misses            ?        5           
  Partials          ?       26
Impacted Files Coverage Δ Complexity Δ
...uorum/tessera/data/migration/JdbcDataExporter.java 100% <100%> (ø) 4 <0> (?)
...rum/tessera/data/migration/SqliteDataExporter.java 100% <100%> (ø) 6 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ada92c...0c1de4c. Read the comment docs.

@melowe melowe merged commit b64a2cf into master Apr 29, 2019
@prd-fox prd-fox deleted the issue-705-lazy-load branch April 29, 2019 15:20
@prd-fox prd-fox added the 0.10.0 label May 3, 2019
@Krish1979 Krish1979 added 0.9.3 bug Something isn't working and removed 0.10.0 bug Something isn't working labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants