Add feature toggle configuration & configurable key validation #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either perform validation or disallow multiple URLs for a key, depending on the toggle activation.
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
============================================
- Coverage 99.48% 99.45% -0.03%
- Complexity 2035 2050 +15
============================================
Files 305 306 +1
Lines 6001 6038 +37
Branches 299 306 +7
============================================
+ Hits 5970 6005 +35
Misses 5 5
- Partials 26 28 +2
Continue to review full report at Codecov.
|
prd-fox
requested review from
chris-j-h,
melowe,
namtruong,
nicolae-leonte-go and
SatpalSandhu61
as code owners
…o node-validation-toggle # Conflicts: # tessera-admin/src/main/java/com/quorum/tessera/admin/ConfigService.java # tessera-partyinfo/src/main/java/com/quorum/tessera/partyinfo/PartyInfoServiceFactory.java # tessera-partyinfo/src/main/java/com/quorum/tessera/partyinfo/PartyInfoServiceImpl.java # tessera-partyinfo/src/test/java/com/quorum/tessera/partyinfo/PartyInfoServiceFactoryTest.java # tessera-partyinfo/src/test/java/com/quorum/tessera/partyinfo/PartyInfoServiceTest.java
melowe
approved these changes
Jul 24, 2019
|
Fixes #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature toggle configuration for future features.
Either perform validation or disallow multiple URLs for a key, depending on the toggle activation.
This will allow breaking changes to be manually activated, until such a time as we want to do a release which enforces the breaking change to be active.