Print more useful error msgs to syserr for service provider errors #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider For example, incorrectly configuring a remote enclave/key vault results in a generic "Provider com.quorum.tessera.p2p.P2PRestApp could not be instantiated" msg presented to the user. By also printing the cause's msg, the BeanCreationExceptions msg is printed, showing the user the exact cause of the error.
chris-j-h
requested review from
melowe,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
prd-fox
previously approved these changes
Aug 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
============================================
+ Coverage 99.44% 99.45% +0.01%
Complexity 2076 2076
============================================
Files 311 311
Lines 6096 6095 -1
Branches 312 311 -1
============================================
Hits 6062 6062
Misses 5 5
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
Krish1979
approved these changes
Aug 19, 2019
prd-fox
approved these changes
Aug 19, 2019
chris-j-h
added a commit
that referenced
this pull request
Sep 2, 2019
) * Print more useful msgs to syserr for errors involving the service provider For example, incorrectly configuring a remote enclave/key vault results in a generic "Provider com.quorum.tessera.p2p.P2PRestApp could not be instantiated" msg presented to the user. By also printing the cause's msg, the BeanCreationExceptions msg is printed, showing the user the exact cause of the error. * Don't print stacktrace, enough info should be present in the msg * Print top level error message and details of root exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859
By also printing the root cause exception, additional useful information will be presented to the user.
Before
After