Only prompt for key passwords on CLI if the pwd is not already given #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-j-h
requested review from
melowe,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
===========================================
+ Coverage 99.3% 99.3% +<.01%
Complexity 2077 2077
===========================================
Files 311 311
Lines 5786 5787 +1
Branches 327 328 +1
===========================================
+ Hits 5746 5747 +1
Misses 5 5
Partials 35 35
Continue to review full report at Codecov.
|
This fixes a bug introduced during refactoring which caused the CLI prompt to occur regardless of whether pwds had already been provided in the configfile. * Add test verifying CLI pwd resolver is not used if pwd already provided * Update an existing test that was a false positive before the bugfix. After the fix, mock encryptor behaviour must be added.
chris-j-h
force-pushed
the
bugfix/unlock-keys
branch
from
c873011
to
5567045
Compare
melowe
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the current 0.11-SNAPSHOT master, introduced during refactoring, which caused the password CLI prompt to occur regardless of whether pwds had already been provided in the configfile.
Resolves #938