Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable p2p polling interval #969

Merged
merged 19 commits into from
Jan 17, 2020
Merged

Conversation

namtruong
Copy link
Collaborator

Introduce new server config item called syncInterval - this will be the rate at which partyinfo rest calls are made.
Default value is 5000 milliseconds.
The timeout of individual requests also will be configured to be 3/4 of the interval if this syncInterval value is set by user

Details at #960

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #969 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #969   +/-   ##
=========================================
  Coverage     99.31%   99.31%           
  Complexity     2179     2179           
=========================================
  Files           329      329           
  Lines          5947     5947           
  Branches        355      355           
=========================================
  Hits           5906     5906           
  Misses            5        5           
  Partials         36       36
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/quorum/tessera/config/Config.java 100% <ø> (ø) 33 <0> (ø) ⬇️
...m/quorum/tessera/config/DefaultKeyVaultConfig.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...com/quorum/tessera/jaxrs/client/ClientFactory.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...um/tessera/config/util/IntervalPropertyHelper.java 100% <ø> (ø) 5 <0> (?)
...va/com/quorum/tessera/config/cli/OverrideUtil.java 100% <ø> (ø) 60 <0> (ø) ⬇️
...ts/MatchingKeyVaultConfigsForKeyDataValidator.java 100% <100%> (ø) 9 <9> (ø) ⬇️
...nstraints/NoDuplicateKeyVaultConfigsValidator.java 100% <100%> (ø) 14 <14> (ø) ⬇️
...ult/hashicorp/HashicorpKeyVaultServiceFactory.java 100% <100%> (ø) 11 <1> (ø) ⬇️
...a/key/vault/azure/AzureKeyVaultServiceFactory.java 92.85% <100%> (ø) 6 <1> (ø) ⬇️
...ssera/key/vault/aws/AWSKeyVaultServiceFactory.java 100% <100%> (ø) 12 <1> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0605c9a...909708a. Read the comment docs.

Have a PropertyHelper to workout the relevant value for scheduled executor
melowe
melowe previously approved these changes Jan 17, 2020
@melowe melowe merged commit 2ac9d90 into master Jan 17, 2020
@Krish1979
Copy link
Collaborator

Fixes #960

@namtruong namtruong deleted the configurable-p2p-polling-interval branch January 17, 2020 15:46
@Krish1979 Krish1979 added 0.10.3 0.10.3 feature User features labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.3 0.10.3 feature User features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants