Enforce whitelist if discovery disabled #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aviour before 0.10. Log message to recommend users to switch on remote key validation for better security
# Conflicts: # cli/config-cli/src/test/java/com/quorum/tessera/config/cli/OverrideUtilTest.java # config/src/main/java/com/quorum/tessera/config/ServerConfig.java # tessera-jaxrs/jaxrs-client/src/main/java/com/quorum/tessera/jaxrs/client/ClientFactory.java # tessera-jaxrs/jaxrs-client/src/test/java/com/quorum/tessera/jaxrs/client/ClientFactoryTest.java # tessera-partyinfo/src/main/resources/tessera-partyinfo-spring.xml
namtruong
requested review from
chris-j-h,
melowe,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
melowe
approved these changes
Jan 17, 2020
Krish1979
approved these changes
Jan 17, 2020
jimmy-dg
pushed a commit
to jimmy-dg/tessera
that referenced
this pull request
Feb 6, 2020
This reverts commit a5d9c51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a network of mixed settings of peer auto-discovery (i.e. some nodes with auto-discovery on and some with auto-discovery switched off), there are chances that a node (says node A) knows about node B, but node B does not know about node A.
In this scenario node B should reject any transactions from node A.
Applying useWhiteList flag should prevent this from happening, so this whitelist check should be mandatory whenever auto-discovery is being switched off.