Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with SonarCloud buildConfiguration variable reference #1

Merged
merged 9 commits into from
Nov 23, 2023

Conversation

CDR-LukeH
Copy link
Contributor

@CDR-LukeH CDR-LukeH commented Nov 23, 2023

Checklist: (Put an x in all the boxes that apply)

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that there aren't any other open Pull Requests from the same change.
  • The develop branch has been set as the base branch to merge changes of the pull request.
  • I have updated the CHANGELOG.md file as appropriate.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
The Sonarcloud Github action fails due to incorrect variable reference in dotnet build command

What is the new behavior? (if this is a feature change)
The Sonarcloud Github action will run successfully.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Copy link

github-actions bot commented Nov 23, 2023

Test Results

1 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit cb86f33.

♻️ This comment has been updated with latest results.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@CDR-LukeH CDR-LukeH changed the title Provide ability to run actions on demand Resolve issue with SonarCloud buildConfiguration variable reference Nov 23, 2023
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CDR-FarooqK CDR-FarooqK self-requested a review November 23, 2023 22:45
Copy link
Contributor

@CDR-FarooqK CDR-FarooqK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@CDR-FarooqK CDR-FarooqK merged commit 69fd7f6 into main Nov 23, 2023
7 checks passed
@CDR-FarooqK CDR-FarooqK deleted the featureonDemandActions branch November 23, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants