Fix panic when no channel is present #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ui-kreinhard
commented
Nov 16, 2021
ui-kreinhard
commented
- This will cause a panic
- Return an appropiate error instead
nexoscp
reviewed
Nov 16, 2021
channel.go
Outdated
| @@ -205,7 +205,9 @@ func (ch *Channel) PublishJSON(exchange, key string, mandatory, immediate bool, | |||
|
|
|||
| func (ch *Channel) PublishJsonAndWaitForResponse(replyQueueName, correlationId string, response, request interface{}, exchange, key string, mandatory, immediate bool, responseTimeout time.Duration) error { | |||
| defer ch.ch.Cancel(replyQueueName+".consumer", false) | |||
There was a problem hiding this comment.
would be better after nil check
* This will cause a panic * Return an appropiate error instead
ui-kreinhard
force-pushed
the
fix_panic_nil
branch
from
a129081
to
be1642f
Compare
nexoscp
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.