Restore RemoteCatalogEntry.metadata. #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In intake 0.4.1, ``entry.metadata`` works the same on local and remote catalogs: it fires implicit ``entry.get()`` and thus accesses ``entry.get().metadata``. On current master, local catalog entries still work that way, but remote catalog entries do not. This is because in f1c61db I wrongly changed `self._metadata` to `self.metadata` and in effected shadowed the "implicit ``get()``" mechanism. It seems worth reviewing at some point whether `self._metadata` should exist, but in the meantime I think this reversion should be merged to get back to the behavior in 0.4.1. I have added a test to protect against making the same mistake in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In intake 0.4.1,
entry.metadataworks the same on local and remote catalogs: it fires implicitentry.get()and thus accessesentry.get().metadata.On current master, local catalog entries still work that way, but remote catalog entries do not. This is because in f1c61db I wrongly changed
self._metadatatoself.metadataand in effect shadowed the "implicitget()" mechanism.It seems worth reviewing at some point whether
self._metadatashould exist at all, but in the meantime I think this reversion should be merged to get back to the behavior in 0.4.1. I have added a test to protect against making the same mistake in the future.