Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED font color doesn't display correctly #1269

Closed
haitao127 opened this issue Apr 16, 2020 · 3 comments
Closed

LED font color doesn't display correctly #1269

haitao127 opened this issue Apr 16, 2020 · 3 comments

Comments

@haitao127
Copy link

I realy like the feature that the LED font changes the color base on the backgroud color, if the LED color is dark, the font changes to a white color, it is good for the readability.

But if the state labels of the LED are the same, this feature doesn't work anymore.

Please look at the video.

@kasemir
Copy link
Collaborator

kasemir commented Apr 16, 2020

Indeed, you're correct, it's about the label. When the label doesn't change, the color isn't recomputed. Thanks for figuring that out!
Will fix it soon.

@kasemir
Copy link
Collaborator

kasemir commented Apr 16, 2020

For what it's worth, the labels are meant to help users with color vision issues. So it's somewhat important to have different labels to clearly indicate the state.
Still, the bug when using the same label has been fixed.

@haitao127
Copy link
Author

Thank you!

@kasemir kasemir closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants