Update to julia v1.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @DANA-Laboratory ,
I made some changes to be able to use CoolProp on Julia 1.0. The tests are passing and I get only four warnings. In the process I did change the structure of the files layout which was probably not the intended method by the library author.
I also realized (only in this very moment) that on CoolProp master branch the file "wrapper/Julia/CoolProp.jl" has been updated a couple of months ago to follow Julia 1.0 updated syntax but unfortunately this updates have not been ported to the package CoolProp.jl which is the one installed by julia CoolProp users.
It would be great if we could move forward to update CoolProp for Julia 1.0
Thanks again for the great work!
Alberto