Inits squirrel@3 #13
Merged
Inits squirrel@3 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godu
force-pushed
the
squirrel-v3
branch
2 times, most recently
from
403e10f
to
830ecdb
Compare
godu
force-pushed
the
squirrel-v3
branch
2 times, most recently
from
68fbca8
to
164d8d7
Compare
| return ready('indexes').then(indexes => { | ||
| return has(key, indexes[index]) ? | ||
| get_(key, indexes[index]).value : | ||
| null; |
There was a problem hiding this comment.
ready('indexes').then(getOr([index, key, 'value'], null)) ?
There was a problem hiding this comment.
enfoiré, tu m'as induit en erreur
_.getOr has an order of (c, b, a)
There was a problem hiding this comment.
Oops, sorry. J'aurai appris quelque chose du coup siffle
|
Quelques simplifications pour ma part, bon boulot @godu 👍 |
| return startsWith(child.key, _path); | ||
| }, node.nodes)); | ||
| }; | ||
| }, 2); |
There was a problem hiding this comment.
Le 2 est inutile ici, et pour le coup, même ignoré dans lodash/fp (curryN si jamais tu en as besoin un jour je crois, avec N probablement en 1er arg)
|
👍 pour moi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.