ETCD3 support #91
Merged
ETCD3 support #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godu
force-pushed
the
etcd3
branch
2 times, most recently
from
0d09bbc
to
8d9bc5c
Compare
jfmengels
reviewed
Feb 14, 2018
| @@ -7,11 +7,14 @@ | |||
| "clean": "rm -rf .nyc_output coverage lib", | |||
| "prepublish": "npm run build", | |||
| "build": "babel src --out-dir lib -s --copy-files", | |||
| "test": "npm run lint && npm run nyc", | |||
| "build:watch": "npm run build -- --watch", | |||
| "test": "npm run nyc", | |||
There was a problem hiding this comment.
On ne fait plus de lint dans Travis et dans npm test du coup ? 🤔
package.json
Outdated
| "test": "npm run lint && npm run nyc", | ||
| "build:watch": "npm run build -- --watch", | ||
| "test": "npm run nyc", | ||
| "test:dev": "npm run lint && npm run ava", | ||
| "lint": "eslint src/ *.js *.json --ext .js,.json", | ||
| "lint:fix": "npm run lint -- --fix", | ||
| "ava": "NODE_ENV=test ava", |
There was a problem hiding this comment.
ava est automatiquement lané avec NODE_ENV=test depuis la 0.23. Du coup on peut lancer ava directement partout sans passer par npm run ava
src/bin/save.js
Outdated
|
|
||
| const client = createEtcd(argz); | ||
| const namespacedClient = client.namespace(namespace); | ||
| save(namespacedClient, outDir).catch(console.error); // eslint-disable-line no-console |
There was a problem hiding this comment.
Si tu veux, on pourrais désactiver cette règle pour le dossier src/bin
src/etcd/test/fetch.js
Outdated
| const fetch$ = createFetch$(client); | ||
|
|
||
| await t.notThrows(fetch$.toPromise()); | ||
|
|
There was a problem hiding this comment.
Teste peut-être la valeur de retour, qu'on ait bien la valeur qui est resolved
| import createStore from '..'; | ||
|
|
||
| test('should get records and indexes', async t => { | ||
| const records$ = new Subject(); |
src/store/test/index.js
Outdated
| t.true(subscription instanceof Subscription); | ||
| }); | ||
|
|
||
| // test('should', async t => { |
| save: false | ||
| }); | ||
|
|
||
| t.truthy(client); | ||
| t.truthy(squirrel); |
There was a problem hiding this comment.
Tu close dans le premier test mais pas dans celui-ci. C'est un oubli ?
jfmengels
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
en attente de microsoft/etcd3#58Drop du support node 6