Add support for FileWrapper to OLEFile

[sboh1214]

Hello, @MaxDesiatov ! Your library is giving me a lot of support for developing HWP File parsing library!

By the way, a problem occurred when I started developing SwiftUI document-based app.
It should get file information from FileWrapper in Foudation Framework.
It's critical because we can't get file path from it.

So, I created OLEFile2, which have fileWrapper property instead of fileHandle. And appended some support code.
Also, I checked it parse same result between OLEFile and OLEFile2.

However, You are core maintainer and I'm just freshmen in univ, so I need your kind advice. 😃
Would it be good to add another class like this?

Thanks!

[sboh1214]

Hmmm, we can't support Linux if the library uses FileWrapper.......
CI / xcode-11_0 (pull_request) and CI / xcode-11_1 (pull_request) failed because it removed from macos github-hosted runner, I think. macos github-hosted runner

[sboh1214]

• I added some preprocessors that checks Linux.

[MaxDesiatov]

Thanks for the PR! Overall I think this approach leads to code duplication, which means we'd have much more code to maintain.

We already have protocol Reader declared, I think we should consider the code in extension FileHandle to be generalized as extension Reader instead. Then firstly we don't need a separate OLEFile2 class, and secondly we could add just another init to OleFile that takes Data instance as an argument and create a DataReader instance from it.

The fileHandle property should then be changed to let reader: Reader, to which we could assign either a FileHandle or a DataReader instance, depending on which is more convenient.

Does that make sense?

[MaxDesiatov]

I've removed Xcode 11.0 and 11.1 jobs from the workflow in the main branch. If you merge main into your branch, those checks should no longer run.

[sboh1214]

Thank @MaxDesiatov for your kind advice! Maybe the code was messy at first because I worked at 4 am lol.

As your suggestion, I integrated OLEFile2 with var reader: Reader.
Yes, it works fine, but there is some weird part in extension FileWrapper because it should conform to Reader.
Its Permalink
Could you check that part?

[MaxDesiatov]

Amazing work, thank you!

[MaxDesiatov]

@sboh1214 I've invited you as a collaborator to the project, feel free to accept the invitation and merge the PR when CI passes 👏

[sboh1214]

Thank you so much @MaxDesiatov !
Could you tag 0.3.0 and publish the release?

[MaxDesiatov]

Sure, but please update CHANGELOG.md first with GitBuddy before tagging the release. You'd launch it like this:

GITBUDDY_ACCESS_TOKEN='sboh1214:REPLACE_WITH_YOUR_GITHUB_TOKEN' gitbuddy changelog --sections -b main

Then add a section for the new version with the current date to CHANGELOG.md and paste the output of the gitbuddy changelog command. You'd create a PR with the changelog update then, which is just a release formality 🙂

Also, this changelog snippet can be added to the release on GitHub itself.

[MaxDesiatov]

If you have any problems with the changelog update, please let me know. I think it's useful for all maintainers on a project to be aware of release processes. Or I can do this myself in the next couple of days, I'm sorry I'm a bit busy right now. Thank you!

[MaxDesiatov]

Ah, sorry, you've explicitly asked to me to tag and release. I'll do it, sorry about the confusion 🤦‍♂️

[sboh1214]

@MaxDesiatov No, it's okay! 😃 I edited it to request to you because I don't know about the release process. But also thank you for letting me know how to release it. Please release OLEKit in your spare time, not hurry.