Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddService and AddServiceEndpoint without generic parameters #204

Closed
FreeAndNil opened this issue Aug 19, 2020 · 1 comment · Fixed by #206
Closed

AddService and AddServiceEndpoint without generic parameters #204

FreeAndNil opened this issue Aug 19, 2020 · 1 comment · Fixed by #206

Comments

@FreeAndNil
Copy link
Contributor

FreeAndNil commented Aug 19, 2020

For porting my WCF-Service I need new overloads for AddService & AddServiceEndpoint:

public void AddService(Type service)
public void AddServiceEndpoint(Type service, Type implementedContract, Binding binding, Uri address, Uri listenUri)

The service application is a generic host and depending on the configuration (in a database) different endpoints must be created (the types are loaded by name via reflection).
I can add the method and create a pull request, just want to confirm that this would be the right way.

@FreeAndNil FreeAndNil changed the title AddServiceEndpoint without generic Parameters AddServiceEndpoint without generic parameters Aug 19, 2020
FreeAndNil pushed a commit to komsa-ag/CoreWCF that referenced this issue Aug 19, 2020
@FreeAndNil FreeAndNil changed the title AddServiceEndpoint without generic parameters AddService and AddServiceEndpoint without generic parameters Aug 19, 2020
FreeAndNil pushed a commit to komsa-ag/CoreWCF that referenced this issue Aug 19, 2020
FreeAndNil pushed a commit to komsa-ag/CoreWCF that referenced this issue Aug 19, 2020
FreeAndNil pushed a commit to komsa-ag/CoreWCF that referenced this issue Aug 19, 2020
FreeAndNil pushed a commit to komsa-ag/CoreWCF that referenced this issue Aug 19, 2020
FreeAndNil pushed a commit to komsa-ag/CoreWCF that referenced this issue Aug 19, 2020
FreeAndNil pushed a commit to komsa-ag/CoreWCF that referenced this issue Aug 19, 2020
@mconnew
Copy link
Member

mconnew commented Aug 19, 2020

Thank you. This just makes sense, I think I got too generic happy by not including them to begin with 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants