Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading more compression formats #37

Merged
merged 9 commits into from
Aug 2, 2024
Merged

Support reading more compression formats #37

merged 9 commits into from
Aug 2, 2024

Conversation

yzqzss
Copy link
Contributor

@yzqzss yzqzss commented Jul 31, 2024

No description provided.

@CorentinB CorentinB requested a review from NGTmeaty July 31, 2024 13:55
@yzqzss yzqzss marked this pull request as draft July 31, 2024 14:58
@yzqzss yzqzss marked this pull request as ready for review July 31, 2024 16:01
NGTmeaty
NGTmeaty requested changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@NGTmeaty NGTmeaty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minus the minor nits)!

Thank you for the PR! There's some great improvements made especially with the WARC version checking, speed improvements to verify, more compression formats, and other general improvements. So thanks!

cmd/verify.go Outdated Show resolved Hide resolved
read.go Outdated Show resolved Hide resolved
read.go Outdated Show resolved Hide resolved
read.go Outdated Show resolved Hide resolved
NGTmeaty
NGTmeaty approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@NGTmeaty NGTmeaty merged commit b52e065 into CorentinB:master Aug 2, 2024
@yzqzss yzqzss deleted the more-decompress branch August 2, 2024 20:06
@CorentinB CorentinB added the enhancement New feature or request label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGTmeaty NGTmeaty NGTmeaty approved these changes

Assignees

@yzqzss yzqzss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yzqzss @NGTmeaty @CorentinB