Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various test improvements #39

Merged
merged 6 commits into from
Aug 3, 2024
Merged

Various test improvements #39

merged 6 commits into from
Aug 3, 2024

Conversation

NGTmeaty
Copy link
Collaborator

@NGTmeaty NGTmeaty commented Aug 3, 2024

Variety of test improvements and minor improvements to verify.

Verified non-chunked test through Heritrix.

software: Heritrix/3.4.0-hq1-SNAPSHOT-2022-05-30T18:40:31Z
---
WARC/1.0
WARC-Type: response
WARC-Target-URI: http://127.0.0.1:35409/
WARC-Date: 2023-08-29T10:18:25Z
WARC-IP-Address: 127.0.0.1
WARC-Payload-Digest: sha1:3TOI6NZK7GYJSFYGATOMMNM2C5VPT3ZD
WARC-Record-ID: <urn:uuid:14d61a70-18a2-42dc-890a-e9d04e61abc5>
Content-Type: application/http; msgtype=response
Content-Length: 161
@NGTmeaty NGTmeaty added the enhancement New feature or request label Aug 3, 2024
@NGTmeaty NGTmeaty requested a review from CorentinB August 3, 2024 09:02
@NGTmeaty NGTmeaty self-assigned this Aug 3, 2024
Copy link
Owner

@CorentinB CorentinB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few cosmetic changes, but looks good to me. We might want to switch to slog at some point to remove logrus.

cmd/verify.go Outdated Show resolved Hide resolved
cmd/verify.go Show resolved Hide resolved
cmd/verify.go Outdated Show resolved Hide resolved
@NGTmeaty NGTmeaty merged commit 9606c9a into master Aug 3, 2024
1 check passed
@NGTmeaty NGTmeaty deleted the jake-test-improvement branch August 6, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants