ZSTD Dictionary support #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows an external ZSTD generated dictionary to be used in the compression process. This implementation will be spec complaint against the IIPC spec and currently works with all known ZSTD WARC tools. It is currently a WIP and needs additional testing and validation to ensure everything is working correctly.
warc/client.go:15:25: struct of size 176 could be 144 warc/client.go:31:23: struct of size 232 could be 216 warc/dedupe.go:23:20: struct with 32 pointer bytes could be 24 warc/dedupe.go:31:20: struct with 48 pointer bytes could be 40 warc/dialer.go:24:19: struct with 168 pointer bytes could be 160 warc/random_local_ip.go:16:19: struct with 24 pointer bytes could be 8 warc/spooled.go:40:22: struct of size 80 could be 72 warc.go:15:22: struct with 72 pointer bytes could be 64 write.go:19:13: struct with 64 pointer bytes could be 56 warc/write.go:32:18: struct with 40 pointer bytes could be 32
warc/client.go:15:25: struct with 96 pointer bytes could be 88 warc/client.go:31:23: struct with 176 pointer bytes could be 168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows an external ZSTD generated dictionary to be used in the compression process. This implementation will be spec complaint against the IIPC spec and currently works with all known ZSTD WARC tools.