Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corfuDBTest.sh script doesn't work for CorfuShell #3

Closed
amytai opened this issue Feb 3, 2015 · 1 comment
Closed

corfuDBTest.sh script doesn't work for CorfuShell #3

amytai opened this issue Feb 3, 2015 · 1 comment
Assignees
@no2chem

Comments

@amytai
Copy link
Contributor

amytai commented Feb 3, 2015

Should remove the < /dev/null on the last line corfuDBTest.sh for the CorfuShell test, because CorfuShell reads input from System.in. Otherwise ./bin/corfuDBTest.sh CorfuShell currently doesn't work.
@no2chem no2chem self-assigned this Feb 12, 2015
@no2chem no2chem closed this as completed Feb 12, 2015
@no2chem no2chem reopened this Feb 12, 2015
@no2chem no2chem added this to the v1.0 Release milestone May 21, 2015
@no2chem
Copy link
Member

no2chem commented May 21, 2015

CorfuShell isn't there anymore, but I'll remove the < /dev/null in case anyone else needs to use stdin in a test.

medhavidhawan added a commit that referenced this issue Jul 27, 2016
@medhavidhawan
Merge pull request #3 from CorfuDB/master
21555b0 
Merging from master
slfritchie pushed a commit to slfritchie/CorfuDB that referenced this issue Oct 24, 2016
Fix bug in prepare & propose state handling found by QuickCheck
6751fbf 
TODO: Fix unit tests that are broken by this change to state mutation.

The error case:

    C3.
    [[{init,{state,false,"sfritchie-m01:8000",
                   [cmdlet0,cmdlet1,cmdlet2,cmdlet3,cmdlet4,cmdlet5,cmdlet6,
                    cmdlet7,cmdlet8,cmdlet9],
                   -1,[],[],0}},
      {set,{var,1},
           {call,layout_qc,reset,
                 [{cmdlet9,'corfu-8000@sfritchie-m01'},
                  "sfritchie-m01:8000"]}},
      {set,{var,3},
           {call,layout_qc,prepare,
                 [{cmdlet4,'corfu-8000@sfritchie-m01'},
                  "sfritchie-m01:8000",0,95]}},
      {set,{var,8},
           {call,layout_qc,commit,
                 [{cmdlet3,'corfu-8000@sfritchie-m01'},
                  "sfritchie-m01:8000",6,95,
                  {layout,22,[],[],[]}]}},
      {set,{var,9},
           {call,layout_qc,prepare,
                 [{cmdlet0,'corfu-8000@sfritchie-m01'},
                  "sfritchie-m01:8000",6,70]}}]]

The output on failure shows step CorfuDB#9's prepare() of rank 70 failing: the
server is erroneously remembering step CorfuDB#3's prepare() rank.

    (qc@sfritchie-m01)3> proper:check(layout_qc:prop(), C3).
    Failed: The input fails the test.
    H: [{{state,false,"sfritchie-m01:8000",
                [cmdlet0,cmdlet1,cmdlet2,cmdlet3,cmdlet4,cmdlet5,cmdlet6,cmdlet7,
                 cmdlet8,cmdlet9],
                -1,[],[],0},
         ["OK"]},
        {{state,true,"sfritchie-m01:8000",
                [cmdlet0,cmdlet1,cmdlet2,cmdlet3,cmdlet4,cmdlet5,cmdlet6,cmdlet7,
                 cmdlet8,cmdlet9],
                -1,[],[],0},
         ["OK"]},
        {{state,true,"sfritchie-m01:8000",
                [cmdlet0,cmdlet1,cmdlet2,cmdlet3,cmdlet4,cmdlet5,cmdlet6,cmdlet7,
                 cmdlet8,cmdlet9],
                95,[],[],0},
         ["OK"]},
        {{state,true,"sfritchie-m01:8000",
                [cmdlet0,cmdlet1,cmdlet2,cmdlet3,cmdlet4,cmdlet5,cmdlet6,cmdlet7,
                 cmdlet8,cmdlet9],
                -1,[],
                {layout,22,[],[],[]},
                0},
         ["ERROR","Exception during prepare",
          "org.corfudb.runtime.exceptions.OutrankedException: Higher rank
95 encountered, layout = null",
          "newRank: 95","layout: "]}]
    S: {state,true,"sfritchie-m01:8000",
              [cmdlet0,cmdlet1,cmdlet2,cmdlet3,cmdlet4,cmdlet5,cmdlet6,cmdlet7,
               cmdlet8,cmdlet9],
              -1,[],
              {layout,22,[],[],[]},
              0}
    R: {postcondition,false}
    false
This was referenced Dec 6, 2017
Merged
Closed
xnull added a commit that referenced this issue Oct 9, 2018
@xnull
Testingframeworkdesign (#3)
a239931 
* Fixed a type in README.md

* Creating testing framework

Co-authored-by: xnull <xrw.null@gmail.com>
Co-authored-by: StrikingThirteen <764389+StrikingThirteen@users.noreply.github.com>

* Creating testing framework

Co-authored-by: xnull <xrw.null@gmail.com>
Co-authored-by: StrikingThirteen <764389+StrikingThirteen@users.noreply.github.com>

* Fix docker command execution

* Creating testing framework: fix DockerCorfuServer disconnect

Co-authored-by: xnull <xrw.null@gmail.com>
Co-authored-by: StrikingThirteen <764389+StrikingThirteen@users.noreply.github.com>
Wenbin Zhu <zwbhsefz@gmail.com>
Miao Cheng <mcheng@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@no2chem no2chem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amytai @no2chem