New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date __eq function may get called with values other than Date. #2293

Merged

TheCycoONE merged 1 commit into CorsixTH:master from Alberth289346:avoid-date-compare-crash

Nov 15, 2022

Contributor

Alberth289346 commented Nov 14, 2022

*Fixes #2290

Describe what the proposed change does

We should check the arguments of the compare functions for being Date instances, but that crashes with infinite recursion in Lua 5.3.
Instead we check for the same __eq functions which works too under the assumption that at least one of the parameters is a Date instance.


          Date __eq function may get called with values other than Date.

c98e2e0

lewri requested a review from TheCycoONE

November 14, 2022 21:57

TheCycoONE merged commit 7f72153 into CorsixTH:master

Alberth289346 deleted the avoid-date-compare-crash branch

November 15, 2022 15:56

lewri added the PR:Bugfix label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels