Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tips window adapt to the space beside the main menu #2482

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

tobylane
Copy link
Member

@tobylane tobylane commented Feb 3, 2024

Fixes #2200

Describe what the proposed change does

  • The width of the tips window is narrower in small resolutions, with stacked previous/next buttons. As it doesn't overlap with the main menu, is this an acceptable place to close and reopen windows without caring about window order?

@TheCycoONE
Copy link
Member

Could you add some screenshots to the PR to illustrate it

@tobylane
Copy link
Member Author

tobylane commented Feb 8, 2024

640x480
Screenshot 2024-02-08 at 13 08 00
800x600
Screenshot 2024-02-08 at 13 08 19
894 wide, the narrowest resolution that has the original, shorter window
Screenshot 2024-02-08 at 13 09 21

@lewri
Copy link
Member

lewri commented Mar 1, 2024

800x600
Screenshot 2024-02-08 at 13 08 19

Should the height not resize itself to the size of the tip?
If we're going to adapt to the resolution horizontally, it might as well also dynamically adjust its height too?

@Alberth289346
Copy link
Contributor

I'd just move the main menu to the left somewhat, the empty sky isn't very interesting anyway.

Not sure that is enough for the tooltip window though

@Alberth289346
Copy link
Contributor

Should the height not resize itself to the size of the tip? If we're going to adapt to the resolution horizontally, it might as well also dynamically adjust its height too?

It's going to show several tips, it should be big enough for all tips. Constantly changing size depending on the amount of text feels like a not-nice solution to me.

Copy link
Member

@lewri lewri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More unlabelled numbers, but that is generally how these windows currently roll.

@lewri lewri merged commit fba1775 into CorsixTH:master Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reposition tips window (where resolution allows?)
4 participants