Check wasm public api before saving #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brew0722
pushed a commit
to brew0722/cosmwasm-1
that referenced
this pull request
Nov 9, 2021
* feat: Add release automation config * fix: remove unneeded cmd * feat: add doc for release * fix: apply review * ci: fix release process * chore: fix generate_release_tag * fix: remove template and fix release.yml * chore: edit docs * fix: change flow * fix: fix error * chore: fix grep format * fix: remove libgcc * fix: add check version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
This adds logic to enforce that the wasm exports all required export functions, and only imports the available imports. We check this in
CosmWasm.save(), which is the main public entrypoint to instantiate contracts. It is also available ascheck_api_compatibility().More than just avoiding garbage contracts, this validates the versioning before failing later on
init(or worse,handle) as there was a cosmwasm version mismatch between runtime and contract.