Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Pair to Record #1116

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Rename Pair to Record #1116

merged 3 commits into from
Sep 28, 2021

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Sep 28, 2021 •
edited
Loading

Closes #1108

ethanfrey
ethanfrey reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ethanfrey
ethanfrey approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve

@webmaster128
Copy link
Member Author

Looking at the diff now it becomes clear that the generic argument V is only needed once the higher level storage methods come in. So what we could do is make Record binary only (for cosmwasm_std and cosmwasm_vm) and use a different type (like BucketRecord) that has a configurable Value type. Not sure if this is worth it though.

@webmaster128 webmaster128 merged commit 5b1ed5c into main Sep 28, 2021
@webmaster128 webmaster128 deleted the pair-to-record branch September 28, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Pair to Record
2 participants
@webmaster128 @ethanfrey