W3 new store #2 #1689
Merged
W3 new store #2 #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1682 on making the cache work.
Main idea is to store an
Engine, which isClonein the cache, instead of aStorethat is not, and reconstruct the store on the consumer side.Seems to be working, with behaviour and performance similar to the main branch.
Still not sure why it's working (and if it's really stable). I mean, in theory it should be possible to build the entire thing (engine plus store) on the consumer side, and cache only the module like before, but for some weird / unknown reason that approach isn't working anymore.