New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignedDecimal implementation #1807

Merged

chipshort merged 26 commits into main from 1711-signed-decimals

Sep 25, 2023

Collaborator

chipshort commented Aug 4, 2023 •

edited

closes #1711

Needs #1870 to work

Current status: Both SignedDecimal and SignedDecimal256 are finished

I added negative cases to almost all tests
I had to adjust these methods (compared to Decimal): from_str, saturating_{add, sub, mul, pow}, to_int_{floor, ceil}
I added some new methods: trunc and to_int_trunc
I removed sqrt, as we don't have it for the signed ints atm and it would have to return a Result in case of negative numbers

webmaster128 mentioned this pull request

Make abs_diff const for all integers #1831

Merged

Member

webmaster128 commented Aug 22, 2023

Adding this to 1.4 for visibility, but would not consider it a hard release blocker. If we can get it in, great.

webmaster128 modified the milestones: 1.4.0, 2.0.0

chipshort force-pushed the 1711-signed-decimals branch 3 times, most recently from 7fdf484 to aea5e42 Compare

September 1, 2023 12:37

chipshort mentioned this pull request

Add abs for all signed ints #1854

Merged

chipshort requested review from webmaster128 and hashedone

September 4, 2023 10:22

Member

webmaster128 commented Sep 6, 2023

Looks very good

I removed sqrt, as we don't have it for the signed ints atm and it would have to return a Result in case of negative numbers

I think it's fine to not have that. Square root of negative numbers only work in complex math. I think users can be asked to convert to unsigned first and ensure errors are handles in that step.

chipshort force-pushed the 1711-signed-decimals branch from d2fe1d6 to 01ee3ac Compare

September 7, 2023 11:13

chipshort mentioned this pull request

Fix shrink_be_int bounds check #1865

Merged

chipshort force-pushed the 1711-signed-decimals branch from 01ee3ac to 458468e Compare

September 11, 2023 09:16

chipshort changed the base branch from main to release/1.4

September 19, 2023 13:27

chipshort force-pushed the 1711-signed-decimals branch from 0f6ba5b to dfccc52 Compare

September 19, 2023 13:27

chipshort changed the base branch from release/1.4 to main

September 19, 2023 13:27

chipshort marked this pull request as ready for review

September 19, 2023 13:27

DariuszDepta self-requested a review

September 22, 2023 13:55

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Outdated Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Outdated Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Outdated Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Outdated Show resolved Hide resolved

DariuszDepta reviewed

View reviewed changes

packages/std/src/math/signed_decimal.rs Outdated Show resolved Hide resolved

webmaster128 approved these changes

View reviewed changes

Member

webmaster128 left a comment

Let's add a CHANGELOG entry here and then merge 🚀

chipshort and others added 25 commits

September 25, 2023 15:40


          Implement signed decimal

ad72e62


          Fix some tests

4f4c88f


          Fix SignedDecimal::saturating_* math

340ea0d


          Fix SignedDecimal::from_str

5fa9425


          Fix tests

e71a34f


          Fix SignedDecimal Display impl

37ae96d


          Fix SignedDecimal::to_int_{floor, ceil}

b9cfb6d


          Fix SignedDecimal::floor

17b906b


          Improve SignedDecimal tests

40256ae


          Improve SignedDecimal docs


          Fix SignedDecimal docs

f86d102


          Add SignedDecimal256

eb99c42


          Add conversions between signed decimals

b385419


          Add conversions between signed + unsigned decimals

0609aff


          Add From and TryFrom impl between decimals

25f9c35


          Remove unnecessary zero check

d82d794


          Fix minor things

0ad3f13


          Constify SignedDecimal256::negative_one

52127d9


          Add must_use messages

1718a17


          Added test cases.

9d1be62


          Adjust assert order

7e6f24e


          Added test cases.

d876842


          Adjust assert order

51162f1


          Fix clippy lints

68802e0


          Add changelog entry

f8d5d8e

chipshort force-pushed the 1711-signed-decimals branch from b555368 to f8d5d8e Compare

September 25, 2023 13:41


          Replace deprecated calls

9989ab9

chipshort merged commit 1e1eb5e into main

27 checks passed

chipshort deleted the 1711-signed-decimals branch

September 25, 2023 14:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment