Add workspace check on merge commit #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
github-check-workspace
branch
from
62c19d8
to
d5e9d24
Compare
webmaster128
force-pushed
the
github-check-workspace
branch
from
d5e9d24
to
c1247d7
Compare
webmaster128
force-pushed
the
github-check-workspace
branch
from
ff18701
to
eca0e37
Compare
chipshort
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inspired by the CI failure in #4035 caused by a successful branch build but an incompatible merge commit between the PR branch and the destination branch (usually main).
The merge commit checks have been an open request in CircleCI for a long time. I don't know if this has been solved in the meantime or not.