Pinned memory cache #700
Merged
Pinned memory cache #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
pinned-memory-cache
branch
3 times, most recently
from
678273b
to
9ba9509
Compare
There was a problem hiding this comment.
Nice work.
Could you also
-
Create a CHANGELOG.md entry (under 0.14.0 (unreleased))
-
Create a new benchmarking case for pinned contract hits
-
Run benchmarks in CI for this PR branch. See
- benchmarking: requires: - package_vm - package_vm_cranelift filters: branches: only: - master # 👇 Add your branch here if benchmarking matters to your work - benchmarking - update-wasmer - metering-restart
Based on InMemoryCache
Try to load module from the fs cache
Try to load module from the memory cache first
maurolacy
force-pushed
the
pinned-memory-cache
branch
from
fc74ff2
to
0d71757
Compare
webmaster128
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #696.
Unit tests of new functionality to follow.Update: Unit tests done. Will now work on an optimized version of the pinning process. But, this is already ready for review.