Small storage-plus docs update #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
reviewed
Sep 20, 2021
Comment on lines
113
to
+117
| part of them. We can efficiently allow pagination over these items as | ||
| well, starting at the point the last query ended, with low gas costs. | ||
| This requires the `iterator` feature to be enabled in `cw-storage-plus` | ||
| (which automatically enables it in `cosmwasm-std` as well). | ||
| (which automatically enables it in `cosmwasm-std` as well, and which is | ||
| enabled by default). |
There was a problem hiding this comment.
IMO this sentence sounds bit confusing.
We can efficiently allow pagination (...). This requires the
iteratorfeature to be enabled incw-storage-plus(which automatically enables it incosmwasm-stdas well, and which is enabled by default).
Maybe change to something like this?
This requires the
iteratorfeature to be enabled incw-storage-plus(it is enabled by default; it also automatically enables it incosmwasm-std).
ueco-jb
approved these changes
Sep 20, 2021
ethanfrey
approved these changes
Sep 20, 2021
| Exclusive(&'a [u8]), | ||
| pub enum Bound { | ||
| Inclusive(Vec<u8>), | ||
| Exclusive(Vec<u8>), |
There was a problem hiding this comment.
We don't have None anymore, right? Just Option<Bound>
There was a problem hiding this comment.
True, missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435