Implement airdrop start expire #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orkunkl
force-pushed
the
merkle-start-expire
branch
from
371678c
to
0dfcc1a
Compare
orkunkl
force-pushed
the
merkle-start-expire
branch
from
0dfcc1a
to
539eb5b
Compare
ethanfrey
reviewed
Dec 28, 2021
| info: MessageInfo, | ||
| stage: u8, | ||
| amount: Uint128, | ||
| proof: Vec<String>, | ||
| ) -> Result<Response, ContractError> { | ||
| // airdrop begun |
There was a problem hiding this comment.
I would pull out these lines (the green diff) into a function like:
is_active(deps: Deps, env: Env, stage: u8) -> StdResult<bool> {}
which you can call here and easily unit test. You may well want to use the same check somewhere else later.
| }; | ||
| execute(deps.as_mut(), env.clone(), info.clone(), msg).unwrap(); | ||
|
|
||
| // can't claim expired |
There was a problem hiding this comment.
comment needs updating "can't claim before it starts"
|
Please move to https://github.com/CosmWasm/cw-tokens You cannot transfer PR. You may be able to cherry-pick commits if you are a git super-star. Or simply apply the patch. I kept the same contract names and paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #606
Useful feature.