Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for entrypoints #13

Merged
merged 18 commits into from
May 23, 2024
Merged

Add documentation for entrypoints #13

merged 18 commits into from
May 23, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Apr 29, 2024

This is just the very very basic outline of the documentation for the entrypoints.
We can improve this later.

The main idea here is to just have some start for the entrypoint docs that we can then iterate on (especially once we document the actor model and some types from the standard library).

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 3:03pm

Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments below. Feel free to put them as TODO comments if you don't want to change all of them in this PR.

src/pages/core/entrypoints/migrate.mdx Outdated Show resolved Hide resolved
src/pages/core/entrypoints/migrate.mdx Outdated Show resolved Hide resolved
src/pages/core/entrypoints/migrate.mdx Show resolved Hide resolved
src/pages/core/entrypoints/migrate.mdx Outdated Show resolved Hide resolved
src/pages/core/entrypoints/execute.mdx Outdated Show resolved Hide resolved
src/pages/core/entrypoints/instantiate.mdx Show resolved Hide resolved
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice examples!

docs-test-gen/templates/core.tpl Outdated Show resolved Hide resolved
src/pages/core/entrypoints/migrate.mdx Outdated Show resolved Hide resolved
src/pages/core/entrypoints/migrate.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few details I noticed

src/pages/core/entrypoints/migrate.mdx Outdated Show resolved Hide resolved
src/pages/core/entrypoints/reply.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aumetra aumetra merged commit fe018e2 into main May 23, 2024
3 checks passed
@aumetra aumetra deleted the entrypoints branch May 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants