Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document instantiate2 #36

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Document instantiate2 #36

merged 6 commits into from
Jun 10, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Jun 7, 2024

This adds a specification of the underlying algorithm used by instantiate2.

Closes #30

TODO:

  • Add tests

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 10:29am

Copy link
Contributor

@dakom dakom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments, but if they need to be addressed it can be in a later PR, nothing blocking :)

src/pages/core/specification/instantiate2-algo.mdx Outdated Show resolved Hide resolved
src/pages/core/specification/instantiate2-algo.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@dakom dakom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, overall lgtm :)

src/pages/core/specification/instantiate2-algo.mdx Outdated Show resolved Hide resolved
@aumetra aumetra merged commit 50fe392 into main Jun 10, 2024
3 checks passed
@aumetra aumetra deleted the aw/instantiate2-spec branch June 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Instantiate2 algorithm
2 participants