Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ACCESS_TYPE_ONLY_ADDRESS? #1142

Closed
3 tasks
webmaster128 opened this issue Jan 4, 2023 · 2 comments · Fixed by #1395
Closed
3 tasks

Remove ACCESS_TYPE_ONLY_ADDRESS? #1142

webmaster128 opened this issue Jan 4, 2023 · 2 comments · Fixed by #1395
Assignees
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented Jan 4, 2023

Now that we have ACCESS_TYPE_ANY_OF_ADDRESSES, can we remove ACCESS_TYPE_ONLY_ADDRESS or is there any good reason to preserve that long term?

I think a migration path could look something like this (over multiple wasmd releases, multiple months):

  • Disallow storing new codes with ACCESS_TYPE_ONLY_ADDRESS (hint to ACCESS_TYPE_ONLY_ADDRESSES in error message) Disallow storing new codes with ACCESS_TYPE_ONLY_ADDRESS #1144
  • Create a migration that converts all ACCESS_TYPE_ONLY_ADDRESS -> ACCESS_TYPE_ONLY_ADDRESSES and string address = 2 -> repeated string addresses = 3.
  • Delete enum case ACCESS_TYPE_ONLY_ADDRESS and field 2 from protos
@alpe
Copy link
Contributor

alpe commented Jan 4, 2023

Thanks for the issue. There are no plans to preserve the type. It was deprecated in code already and can be removed. Your migration path makes sense 👍

@webmaster128
Copy link
Member Author

Cool, I'll split the steps in small tickets such that we can do them over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants