Add partial coordinates #122

tbrezot · 2024-01-16T18:42:33Z

Partial coordinates allow ciphertexts created with an access policy "D1::A" not to be invalidated upon addition or deletion of another dimension/attribute.

The number of coordinate derived from the policy ("universe") is the product of the cardinal of the dimensions, plus one:

$$\prod_{dim}(|dim| + 1)$$

Breaking changes

The master keys hold the coordinates of all the subspaces.
The user keys hold the coordinates of the semantic subspace of their associated access policy. A semantic subspace is defined as the envelop of the points of the conjunctions defined by the DNF of the associated policy. In other words, this is the smallest valid subspace in which the access policy can be expressed.
Re-keying and pruning are performed using the semantic subspaces (so as to allow easily re-keying all coordinates associated to a leaked user key).
Encapsulations are created for all the points defined by the conjunctions in the DNF of the associated access policy. This means that "D1::A && (D2::A || D2::B)" <=> "D1::A && D2::A || D1::A && D2::B" generates two coordinates and the access policy "" generates one coordinate (the 0 of the universe), which allow for an efficient broadcast.

Work in progress

ensure adding and deleting other dimensions or attributes does not invalidate any ciphertext/user key which associated access policy leaves in a different subspace.
validate the creation of user key and re-keying/prunning per semantic space

ackRow

Nice refacto!

src/abe_policy/access_policy.rs

src/abe_policy/dimension.rs

Manuthor

great job!
I suppose you will complete this PR with benches and the last item of you WIP list.
Otherwise, all good to me.

src/abe_policy/access_policy.rs

- remove benches (see `fix/benches`) - remove `serialization` feature to fix tests that depend on it.

Simplify parsing code and correct parsing errors. Notice that now, empty access policies can be parsed. Parsing should be more efficient too, but we lack benchmarks for that. The only downside is that allowing '&' or '|' inside attributes is painful to write. I consider it an acceptable limitation to the expressivness allowed by the parsing operation. This is a breaking change though. All "Department::R&D" attributes have been renamed into "Department::RD".

…124) feat: add partial coordinates fix: cargo test --all-features - remove benches (see `fix/benches`) - remove `serialization` feature to fix tests that depend on it. fix: access policy parsing Simplify parsing code and correct parsing errors. Notice that now, empty access policies can be parsed. Parsing should be more efficient too, but we lack benchmarks for that. The only downside is that allowing '&' or '|' inside attributes is painful to write. I consider it an acceptable limitation to the expressivness allowed by the parsing operation. This is a breaking change though. All "Department::R&D" attributes have been renamed into "Department::RD". fix: access policy parsing rename!: rename `from_boolean_expression` into `parse` fix: neats

Work done in `feat/partial_coordinates` breaks the current benchmarks. Later MR will reintroduce new benchmarks compatible with the new inner workings of the key derivation.

wip: feat: merge msk/mpk removing buggy benches fix: `crypto_core` dependency link fix: cleanup remaining mention of Curve25519 in `primitives.rs` fix: tests encaps/decaps fix: serialization fix: rebase fix: rename ElGamal encryption to masking primitives fix: review Rename `chronological_iter` back to `bfs`

Adamk93

I don't have real comments on this PR

Co-authored-by: Théophile BRÉZOT <theophile.brezot@cosmian.com>

Merge policy object

tbrezot requested review from Manuthor and ackRow and removed request for Manuthor January 16, 2024 18:42

tbrezot marked this pull request as draft January 16, 2024 18:42

tbrezot force-pushed the feat/partial_coordinates branch from f31bb46 to a476bc5 Compare January 18, 2024 13:49

tbrezot marked this pull request as ready for review January 26, 2024 15:54

tbrezot force-pushed the feat/partial_coordinates branch from f37d53f to ca3f1cc Compare January 26, 2024 16:07

tbrezot mentioned this pull request Jan 26, 2024

Merge MPK/MSK + review crypto operations #125

Merged

2 tasks

ackRow reviewed Feb 5, 2024

View reviewed changes

src/abe_policy/access_policy.rs Outdated Show resolved Hide resolved

src/abe_policy/dimension.rs Show resolved Hide resolved

Manuthor reviewed Feb 6, 2024

View reviewed changes

src/abe_policy/access_policy.rs Show resolved Hide resolved

tbrezot mentioned this pull request Mar 4, 2024

Rekey: fix policy parsing #130

Merged

tbrezot and others added 10 commits March 18, 2024 14:32

feat: add partial coordinates

343e1f1

fix: cargo test --all-features

4ef2054

- remove benches (see `fix/benches`) - remove `serialization` feature to fix tests that depend on it.

fix: access policy parsing

78e6351

rename!: rename from_boolean_expression into parse

b5aefe6

fix: neats

1dee2fc

fix: review

182bb1b

fix: remove benchmarks

0f08eef

Work done in `feat/partial_coordinates` breaks the current benchmarks. Later MR will reintroduce new benchmarks compatible with the new inner workings of the key derivation.

fix: rename Partition into Coordinate

5275698

tbrezot force-pushed the feat/partial_coordinates branch from f3e6134 to 5275698 Compare March 18, 2024 13:45

tbrezot and others added 3 commits March 18, 2024 15:11

todo : refactoring API. Just declared KEM and PKE traits

aeb481d

fix: cleanup

cafa459

tbrezot requested a review from Adamk93 March 22, 2024 08:13

Adamk93 previously approved these changes Mar 24, 2024

View reviewed changes

Adam Khayam and others added 2 commits March 24, 2024 16:50

little implem of last week. TBD with Theo

6ef8607

toward implementation of a generic dem interface

4296d9a

tbrezot and others added 30 commits October 28, 2024 15:36

Check all subkeys are of the same hybridation type upon encapsulating

a1142c0

use Kyber CCA

f5c5bdc

use pqc_kyber without hazmat feature

85e7465

use instead of recoding it

022d18e

remove the eakem_hash! macro

80ed204

Use released CryptoCore version

3b9293a

include policy in mpk and msk structs

b28d2e3

update functions parameters

2464ae1

implement read for policy

715d9ce

implement read for policy

da1df51

rebase on partial_coordinates branch

e7f1d30

fix some errors after rebase

ae73e47

try to pass tests

415439b

try to pass tests

018aa00

try to pass tests

cf2459e

try to pass tests

0301098

add new line at the end of rs file

750404e

Merge branch 'feat/partial_coordinates' into merge_policy_object

9e24cb7

try to pass tests

8d4131c

try to pass tests

72de55c

use Theophile fix

535e727

Update src/abe_policy/attribute.rs

f7fb1f6

Co-authored-by: Théophile BRÉZOT <theophile.brezot@cosmian.com>

Update src/core/serialization/mod.rs

33e6ee1

Co-authored-by: Théophile BRÉZOT <theophile.brezot@cosmian.com>

Update src/test_utils/non_regression.rs

6e582e3

Co-authored-by: Théophile BRÉZOT <theophile.brezot@cosmian.com>

pr review

8861353

cargot fmt

64fa10e

cargo fmt

f3f5efa

cargo fmt

3a77352

cargo fmt

6371a65

Merge pull request #137 from Cosmian/merge_policy_object

b91c99d

Merge policy object

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add partial coordinates #122

Add partial coordinates #122

tbrezot commented Jan 16, 2024 •

edited

Loading

ackRow left a comment

Manuthor left a comment

Adamk93 left a comment

Add partial coordinates #122

Are you sure you want to change the base?

Add partial coordinates #122

Conversation

tbrezot commented Jan 16, 2024 • edited Loading

Breaking changes

Work in progress

ackRow left a comment

Choose a reason for hiding this comment

Manuthor left a comment

Choose a reason for hiding this comment

Adamk93 left a comment

Choose a reason for hiding this comment

tbrezot commented Jan 16, 2024 •

edited

Loading